Include :open in the open variant#15349
Merged
Merged
Conversation
open now matches the new `:open` pseudo class.
Contributor
Author
|
@RobinMalfait now that v4 is out, is this addition something you'd be open to? |
Member
|
Yep, I think this is a good idea, especially because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
openvariant to addtionally match the new:openpseudo class.See spec at https://drafts.csswg.org/selectors-4/#open-state
See Chromium intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/Pdo4oOXYKcA
:openmatches open<details>and<dialog>elements (already covered by [open]), but also matches select elements with their picker open and inputs with their picker open.Thanks to
:is()taking a forgiving selector list, this is safe to add even with limited browser support.